Home Explore Help
Sign In
oss
/
openadk
4
1
Fork 3
Files Issues 1 Pull Requests 0 Wiki
Labels Milestones
New Pull Request

#14 fail when checking out git repository and commit doesn't exist

Merged
wbx merged 1 commits from ableton-dir/master into oss/master 6 years ago
Conversation 1 Commits 1 Files changed 1
ableton-dir commented 6 years ago

This created a few head scratches - due to the subshell command, the checkout of a concrete hash fails silently, creating mismatched packages downstream. This PR propagates the error message in that case. I wonder if there is a more general solution to this (not being a shell expert), as similar things happen for us in a few scenarios (e.g. install.sh fails silently, too)

This created a few head scratches - due to the subshell command, the checkout of a concrete hash fails silently, creating mismatched packages downstream. This PR propagates the error message in that case. I wonder if there is a more general solution to this (not being a shell expert), as similar things happen for us in a few scenarios (e.g. install.sh fails silently, too)
wbx closed 6 years ago
Waldemar Brodkorb commented 6 years ago
Owner

Not sure what a general solutions would be. May be we should add more checking into install.sh, too.

Not sure what a general solutions would be. May be we should add more checking into install.sh, too.
This pull request has been merged successfully!
Sign in to join this conversation.
Labels
Clear labels
No Label
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
2 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.