Browse Source

install_headers: properly quote things

Denis Vlasenko 16 years ago
parent
commit
0c55850e1f
1 changed files with 4 additions and 3 deletions
  1. 4 3
      extra/scripts/install_headers.sh

+ 4 - 3
extra/scripts/install_headers.sh

@@ -59,10 +59,11 @@ if ! test "$KERNEL_HEADERS" \
 	echo "Check KERNEL_HEADERS= in your .config file."
 	exit 1
 fi
-# Do the copying only if src and dst dirs are not the same
+# Do the copying only if src and dst dirs are not the same.
 # Be thorough: do not settle just for textual compare,
-# and guard against "pwd" being handled as shell builtin
-if test `(cd "$KERNEL_HEADERS"; env pwd)` != `(cd "$2"; env pwd)`; then
+# and guard against "pwd" being handled as shell builtin.
+# Double quoting looks weird, but it works (even bbox ash too).
+if test "`(cd "$KERNEL_HEADERS"; env pwd)`" != "`(cd "$2"; env pwd)`"; then
 	# NB: source or target files and directories may be symlinks,
 	# and for all we know, good reasons.
 	# We must work correctly in these cases. This includes "do not replace