Parcourir la source

trivial code shrink by making some strings static

    text           data     bss     dec     hex filename
-    259              0       0     259     103 libc/inet/herror.o
+    243              0       0     243      f3 libc/inet/herror.o
-    720              0       0     720     2d0 libc/inet/ns_name.o
+    710              0       0     710     2c6 libc/inet/ns_name.o
Denis Vlasenko il y a 15 ans
Parent
commit
147526abfe
3 fichiers modifiés avec 12 ajouts et 11 suppressions
  1. 6 8
      libc/inet/herror.c
  2. 4 2
      libc/inet/resolv.c
  3. 2 1
      libc/misc/mntent/mntent.c

+ 6 - 8
libc/inet/herror.c

@@ -26,7 +26,7 @@
 libc_hidden_proto(fprintf)
 libc_hidden_proto(__h_errno_location)
 
-static const char *error_msg = "Resolver error";
+static const char error_msg[] = "Resolver error";
 static const char *const h_errlist[] = {
 	"Error 0",
 	"Unknown host",			    /* 1 HOST_NOT_FOUND */
@@ -52,7 +52,7 @@ void herror(const char *s)
 	}
 	p = error_msg;
 	if ((h_errno >= 0) && (h_errno < h_nerr)) {
-	    p = h_errlist[h_errno];
+		p = h_errlist[h_errno];
 	}
 	fprintf(stderr, "%s%s%s\n", s, c, p);
 }
@@ -61,10 +61,8 @@ libc_hidden_def(herror)
 
 const char *hstrerror(int err)
 {
-    if (err < 0) {
-	return(error_msg);
-    } else if (err < h_nerr) {
-	return(h_errlist[err]);
-    }
-    return(error_msg);
+	if ((unsigned)err < h_nerr)
+		return(h_errlist[err]);
+
+	return error_msg;
 }

+ 4 - 2
libc/inet/resolv.c

@@ -2625,12 +2625,14 @@ libc_hidden_def(ns_name_uncompress)
  *      The root is returned as "."
  *      All other domains are returned in non absolute form
  */
-int ns_name_ntop(const u_char *src, char *dst, size_t dstsiz) {
+int ns_name_ntop(const u_char *src, char *dst, size_t dstsiz)
+{
+	static const char digits[] = "0123456789";
+
 	const u_char *cp;
 	char *dn, *eom;
 	u_char c;
 	u_int n;
-	const char digits[] = "0123456789";
 
 	cp = src;
 	dn = dst;

+ 2 - 1
libc/misc/mntent/mntent.c

@@ -30,8 +30,9 @@ libc_hidden_proto(fprintf)
 struct mntent *getmntent_r (FILE *filep,
 	struct mntent *mnt, char *buff, int bufsize)
 {
+	static const char sep[] = " \t\n";
+
 	char *cp, *ptrptr;
-	const char *sep = " \t\n";
 
 	if (!filep || !mnt || !buff)
 	    return NULL;