Browse Source

Fix arm syscall implementation so it does not blow chunks with gcc 3.3
-Erik

Eric Andersen 21 years ago
parent
commit
461e8b2861
2 changed files with 25 additions and 9 deletions
  1. 24 8
      libc/sysdeps/linux/arm/bits/syscalls.h
  2. 1 1
      libc/sysdeps/linux/arm/syscall.c

+ 24 - 8
libc/sysdeps/linux/arm/bits/syscalls.h

@@ -18,7 +18,7 @@
 
 /*
    Some of the sneaky macros in the code were taken from 
-   glibc-2.2.5/sysdeps/unix/sysv/linux/arm/sysdep.h
+   glibc-2.3.2/sysdeps/unix/sysv/linux/arm/sysdep.h
 */
 
 #ifndef __ASSEMBLER__
@@ -84,7 +84,20 @@ return (type) (INLINE_SYSCALL(name, 7, arg1, arg2, arg3, arg4, arg5, arg6, arg7)
 
 
 #undef INLINE_SYSCALL
-#define INLINE_SYSCALL(name, nr, args...)			\
+#define INLINE_SYSCALL(name, nr, args...)				\
+  ({ unsigned int _sys_result = INTERNAL_SYSCALL (name, , nr, args);	\
+     if (__builtin_expect (INTERNAL_SYSCALL_ERROR_P (_sys_result, ), 0))	\
+       {								\
+	 __set_errno (INTERNAL_SYSCALL_ERRNO (_sys_result, ));		\
+	 _sys_result = (unsigned int) -1;				\
+       }								\
+     (int) _sys_result; })
+
+#undef INTERNAL_SYSCALL_DECL
+#define INTERNAL_SYSCALL_DECL(err) do { } while (0)
+
+#undef INTERNAL_SYSCALL
+#define INTERNAL_SYSCALL(name, err, nr, args...)		\
   ({ unsigned int _sys_result;					\
      {								\
        register int _a1 asm ("a1");				\
@@ -92,16 +105,18 @@ return (type) (INLINE_SYSCALL(name, 7, arg1, arg2, arg3, arg4, arg5, arg6, arg7)
        asm volatile ("swi	%1	@ syscall " #name	\
 		     : "=r" (_a1)				\
 		     : "i" (SYS_ify(name)) ASM_ARGS_##nr	\
-		     : "a1", "memory");				\
+		     : "memory");				\
        _sys_result = _a1;					\
      }								\
-     if (_sys_result >= (unsigned int) -4095)			\
-       {							\
-	 __set_errno (-_sys_result);				\
-	 _sys_result = (unsigned int) -1;			\
-       }							\
      (int) _sys_result; })
 
+#undef INTERNAL_SYSCALL_ERROR_P
+#define INTERNAL_SYSCALL_ERROR_P(val, err) \
+  ((unsigned int) (val) >= 0xfffff001u)
+
+#undef INTERNAL_SYSCALL_ERRNO
+#define INTERNAL_SYSCALL_ERRNO(val, err)	(-(val))
+
 #define LOAD_ARGS_0()
 #define ASM_ARGS_0
 #define LOAD_ARGS_1(a1)				\
@@ -133,5 +148,6 @@ return (type) (INLINE_SYSCALL(name, 7, arg1, arg2, arg3, arg4, arg5, arg6, arg7)
   LOAD_ARGS_6 (a1, a2, a3, a4, a5, a6)
 #define ASM_ARGS_7	ASM_ARGS_6, "r" (_v3)
 
+
 #endif /* __ASSEMBLER__ */
 #endif /* _BITS_SYSCALLS_H */

+ 1 - 1
libc/sysdeps/linux/arm/syscall.c

@@ -39,7 +39,7 @@ long syscall(long sysnum, long a, long b, long c, long d, long e, long f)
 	    : "i"(__NR_syscall), "r"(_r0), "r"(_r1),
 	      "r"(_r2), "r"(_r3), "r"(_r4), "r"(_r5),
 	      "r"(_r6)
-	    : "r0", "memory");
+	    : "memory");
     if(_r0 >=(unsigned long) -4095) {
 	(*__errno_location())=(-_r0);
 	_r0=(unsigned long) -1;