Browse Source

statfs: bugfix statfs02 fstatfs02 failed in ltp-testsuite

In the test-case of statfs from ltp-testsuite, it pass -1 to 2th
argument. eg: fstatfs(fd , -1)

When uclibc-ng parse the buf32 to buf will cause illegal address
access, the kernel will signal the process with SIGSEGV.

If we pass the -1 directly to the syscall of statfs/fstatfs, kernel
use copy_to_user() to prevent the signal of SIGSEGV and just return
EINVAL.

This is the ltp-testsuite expect.

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Guo Ren 6 years ago
parent
commit
7cfd2112ac
2 changed files with 6 additions and 2 deletions
  1. 3 1
      libc/misc/statfs/fstatfs64.c
  2. 3 1
      libc/misc/statfs/statfs64.c

+ 3 - 1
libc/misc/statfs/fstatfs64.c

@@ -33,9 +33,11 @@ int fstatfs64 (int fd, struct statfs64 *buf)
 {
     struct statfs buf32;
 
-    if (__libc_fstatfs (fd, &buf32) < 0)
+    if (__libc_fstatfs (fd, (struct statfs *)buf) < 0)
 	return -1;
 
+    buf32 = *(struct statfs *)buf;
+
     buf->f_type = buf32.f_type;
     buf->f_bsize = buf32.f_bsize;
     buf->f_blocks = buf32.f_blocks;

+ 3 - 1
libc/misc/statfs/statfs64.c

@@ -31,9 +31,11 @@ int statfs64 (const char *file, struct statfs64 *buf)
 {
     struct statfs buf32;
 
-    if (__libc_statfs (file, &buf32) < 0)
+    if (__libc_statfs (file, (struct statfs *)buf) < 0)
 	return -1;
 
+    buf32 = *(struct statfs *)buf;
+
     buf->f_type = buf32.f_type;
     buf->f_bsize = buf32.f_bsize;
     buf->f_blocks = buf32.f_blocks;