Browse Source

Blackfin: fix incorrect attribute order

The order of attributes in a function definition matters and in a few
places in the Blackfin code, it was being applied to the return type
instead of the function itself.

In file included from ldso/ldso/ldso.c:43:
ldso/ldso/bfin/elfinterp.c: At top level:
ldso/ldso/bfin/elfinterp.c:42: warning: '__visibility__' attribute ignored on non-class types

In file included from ldso/ldso/bfin/elfinterp.c:341,
                 from ldso/ldso/ldso.c:43:
libc/sysdeps/linux/bfin/crtreloc.c: At top level:
libc/sysdeps/linux/bfin/crtreloc.c:91: warning: 'visibility' attribute ignored on non-class types

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger 16 years ago
parent
commit
aafd587b8b
2 changed files with 3 additions and 2 deletions
  1. 2 1
      ldso/ldso/bfin/elfinterp.c
  2. 1 1
      libc/sysdeps/linux/bfin/crtreloc.c

+ 2 - 1
ldso/ldso/bfin/elfinterp.c

@@ -37,7 +37,8 @@ USA.  */
    a more than adequate job of explaining everything required to get this
    a more than adequate job of explaining everything required to get this
    working. */
    working. */
 
 
-struct funcdesc_value volatile *__attribute__((__visibility__("hidden")))
+__attribute__((__visibility__("hidden")))
+struct funcdesc_value volatile *
 _dl_linux_resolver (struct elf_resolve *tpnt, int reloc_entry)
 _dl_linux_resolver (struct elf_resolve *tpnt, int reloc_entry)
 {
 {
 	ELF_RELOC *this_reloc;
 	ELF_RELOC *this_reloc;

+ 1 - 1
libc/sysdeps/linux/bfin/crtreloc.c

@@ -85,7 +85,7 @@ reloc_range_indirect (void ***p, void ***e,
 /* Call __reloc_range_indirect for the given range except for the last
 /* Call __reloc_range_indirect for the given range except for the last
    entry, whose contents are only relocated.  It's expected to hold
    entry, whose contents are only relocated.  It's expected to hold
    the GOT value.  */
    the GOT value.  */
-void* attribute_hidden
+attribute_hidden void*
 __self_reloc (const struct elf32_fdpic_loadmap *map,
 __self_reloc (const struct elf32_fdpic_loadmap *map,
 	      void ***p, void ***e)
 	      void ***p, void ***e)
 {
 {